Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

feat: simplifies manifest structure for the plugin #932

Closed
wants to merge 7 commits into from
Closed

feat: simplifies manifest structure for the plugin #932

wants to merge 7 commits into from

Conversation

bartoszmajsak
Copy link

@bartoszmajsak bartoszmajsak commented Sep 13, 2023 •
edited
Loading

⚠️ Important note

These changes require opendatahub-io/opendatahub-operator#515 to be released.

Follow the description in that PR to see how this can be tested.

Description

This PR introduces several enhancements and fixes aimed at simplifying the plugin setup and improving documentation:

  • Features

    • Simplifies the manifest structure for easier plugin configuration. Primarily removes all init-job logic in favor of the plugin.
    • Defines configuration map values for Open Service Mesh (OSSM) which are used across components. (such as USE_ISTIO flag)

  • Fixes

    • Correctly defines new images in the overlay settings.

  • Chores

    • Align image tags to use the service-mesh-integration.
    • Updates the kfdef example for better clarity.

How Has This Been Tested?

See opendatahub-io/opendatahub-operator#515

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

This was referenced Sep 13, 2023
Closed
Open
cam-garrison
cam-garrison approved these changes Sep 19, 2023
View reviewed changes
enabling-ossm.md Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cam-garrison
Once this PR has been reviewed and has the lgtm label, please assign lavlas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Sep 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2023

New changes are detected. LGTM label has been removed.

@bartoszmajsak
Copy link
Author

As opendatahub-io/opendatahub-operator#515 is not going to be implemented this change is not needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cam-garrison cam-garrison cam-garrison approved these changes

@aslakknutsen aslakknutsen Awaiting requested review from aslakknutsen

@VaishnaviHire VaishnaviHire Awaiting requested review from VaishnaviHire

Assignees

@cam-garrison cam-garrison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartoszmajsak @cam-garrison